-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Move htmlSafe and isHTMLSafe to @ember/component #36
Conversation
We can't do this. This is a breaking change! |
With current format, there cannot be two shims for the same function. Shall I change the format? |
Changing the format is also a breaking change. |
Is this project not on v0.2.7? |
v0.2.7 of what? I don't understand the question |
How does this impact helpers? |
Hello @martletandco: That's an interesting point. Can you repeat it in emberjs/rfcs#236 ? I think it is worth it :) Thank you! |
Sure we can, we just need a major version bump here. |
IMHO, the current JSON format needs a bit of reworking to accommodate multiple import paths pointing to a single global. We should focus on deciding what the new format is, so that the underlying work can begin. |
My suggestion: [
{
"global": "Ember.String.isHTMLSafe",
"module": "@ember/component",
"export": "isHTMLSafe",
"deprecated": true,
"replacement": { "module": "@ember/template", "export": "isHTMLSafe" }
},
{
"global": "Ember.String.isHTMLSafe",
"module": "@ember/template",
"export": "isHTMLSafe",
"deprecated": false
},
{
"global": "Ember.Component",
"module": "ember-component",
"export": "default",
"deprecated": true,
"replacement": { "module": "@ember/component", "export": "default" }
},
{
"global": "Ember.Component",
"module": "@ember/component",
"export": "default",
"deprecated": false
}
] |
I believe #38 supersedes this one. |
Related to emberjs/rfcs#236.
Task in emberjs/ember.js#15624