This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
Added Glimmer component example to Readme
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Feb 22, 2019
Sparkles works with Ember 3.4+ (aka non-canary Ember versions) so I don't think we should tell folks to swap just yet. However, I do think we should add some blurb to the sparkles-component README that explains that in the long run folks should be using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example on the Readme for the Glimmer component API.
babel-plugin-ember-modules-api-polyfill 2.7.0is automatically installed with the blueprint; the Glimmer API works 🎆Pending to bump
ember-cli-babelwhen released: ember-cli/ember-rfc176-data#113Should the Readme of the
sparkles-componentbeing updated to recommend using this setup instead?cc @rwjblue