Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure app content always wins #8048

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Make sure app content always wins #8048

merged 1 commit into from
Sep 13, 2018

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Sep 13, 2018

fixes #8042

@twokul twokul requested a review from rwjblue September 13, 2018 18:24
rwjblue
rwjblue reviewed Sep 13, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good can you throw together a test?

@rwjblue rwjblue merged commit 64b0b72 into ember-cli:release Sep 13, 2018
@twokul twokul deleted the merge-order branch September 13, 2018 23:10
@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2018

(Test can follow in an upcoming PR)

@Turbo87 Turbo87 mentioned this pull request Sep 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twokul @rwjblue