Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t produce duplicate warnings when invoking findAddonByName with a… #7965

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

stefanpenner
Copy link
Contributor

…n ambiguous add-on name

@stefanpenner stefanpenner requested a review from rwjblue August 7, 2018 02:11
@stefanpenner
Copy link
Contributor Author

stefanpenner commented Aug 7, 2018

failures seem unrelated:

not ok 335 EmberApp vendorFiles does not include jquery if the app has `@ember/optional-features` with the `jquery-integration` FF turned off
  AssertionError: expected [ Array(3) ] to deeply equal [ 'ember.js', 'app-shims.js' ]
      at Context.<anonymous> (tests/unit/broccoli/ember-app-test.js:1314:52)

<snip>

not ok 347 EmberApp: Bower Dependencies "after each" hook: createPromise for "are not packaged unless explicitly imported"
  TypeError: Cannot read property 'dispose' of undefined
      at Context.<anonymous> (tests/unit/broccoli/ember-app/import-test.js:34:18)
      at Generator.next (<anonymous>)
      at onFulfilled (node_modules/co/index.js:65:19)

@stefanpenner stefanpenner changed the base branch from master to beta August 7, 2018 02:24
@stefanpenner
Copy link
Contributor Author

@rwjblue the tests seem to be failing for an unrelated issue. I'll try to look into this in the AM.

@rwjblue rwjblue merged commit ee97795 into beta Aug 7, 2018
@rwjblue rwjblue deleted the beta-fix-noise branch August 7, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants