Fix travis.yml in addon blueprint
#7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Oct 10, 2017
blueprints/addon/files/.travis.yml
Outdated
| @@ -22,6 +22,7 @@ env: | |||
| global: | |||
| # See https://git.io/vdao3 for details. | |||
| - JOBS=1 | |||
| matrix: | |||
| # we recommend new addons test the current and previous LTS | |||
| # as well as latest stable release (bonus points to beta/canary) | |||
| - EMBER_TRY_SCENARIO=ember-lts-2.8 | |||
There was a problem hiding this comment.
I think this comment and the list items need to be indented an extra 2 spaces.
|
Thank you!
|
simonihmig
force-pushed
the
fix-addon-travis
branch
from
5fbcd52 to
4b3cf00
Compare
simonihmig
force-pushed
the
fix-addon-travis
branch
from
4b3cf00 to
0c8d0aa
Compare
simonihmig
force-pushed
the
fix-addon-travis
branch
from
0c8d0aa to
55acba1
Compare
rwjblue
approved these changes
Oct 10, 2017
Turbo87
changed the title
travis.yml in addon blueprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running
ember-cli-updatein an addon and pushing, the Travis build was broken with a yaml parsing error: https://travis-ci.org/kaliber5/ember-window-mock/builds/286204403The changes were introduced in #7349, but this does indeed not seem like valid yaml (
envbeing used as object as well as array). Travis docs show this: https://docs.travis-ci.com/user/environment-variables/#Global-VariablesAfter adding the additional
matrixkey, this fixed my build...