Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating app/addon blueprints to latest dependency versions #6139

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Updating app/addon blueprints to latest dependency versions #6139

merged 1 commit into from
Aug 2, 2016

Conversation

elwayman02
Copy link
Contributor

No description provided.

@stefanpenner
Copy link
Contributor

awesome, thanks!

@elwayman02
Copy link
Contributor Author

Whoo passed!

@twokul
Copy link
Contributor

twokul commented Aug 2, 2016

@homu r+

@twokul twokul merged commit 117806d into ember-cli:master Aug 2, 2016
@Turbo87
Copy link
Member

Turbo87 commented Aug 2, 2016

other than the shims update what's the reason for this? since they use caret ranges the deps should use the most recent versions anyway and updating them just creates unnecessary work for people updating their apps.

@Turbo87 Turbo87 added this to the v2.9.0 milestone Aug 2, 2016
@elwayman02
Copy link
Contributor Author

I would actually argue that it creates less work in the long run. Instead
of forcing individual developers to do this work manually, now they can
simply run Ember init to get this for free. Because it's still within the
karat versions, they don't have to worry about regressions. Additionally,
there is some functional value, as platforms like Travis-CI have been known
to aggressively cache packages and troll people by running older versions
that still satisfy the fuzzy versioning, rather than pulling in the latest
allowed release. Updating the minimum version will invalidate the cache so
that developers don't have to manually troubleshoot why their app didn't
pick up the latest package version that they have on their local
environment.

On Tue, Aug 2, 2016, 12:28 AM Tobias Bieniek notifications@github.com
wrote:

other than the shims update what's the reason for this? since they use
caret ranges the deps should use the most recent versions anyway and
updating them just creates unnecessary work for people updating their apps.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6139 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQ5qrqqml5lTVdHxhggO3GCgNaXsWeDks5qbvGjgaJpZM4JaIcS
.

@twokul
Copy link
Contributor

twokul commented Aug 2, 2016

@Turbo87 I run into so many deprecation (this._super) issues b/c version weren't resolved properly or there were 300500 versions of ember-cli-htmlbars which differed in point version

@Turbo87
Copy link
Member

Turbo87 commented Aug 2, 2016

good point @twokul, I guess it's worth updating then.

@elwayman02 elwayman02 deleted the update-blueprint-packages branch August 2, 2016 18:45
@lisajacobson
Copy link

When I upgraded to ember 2.8.0, running ember init deleted a handful of dependencies that I am now in the process of checking compatibility with this latest stable ember release. Is there a quicker fix to cross-check compatibility? Also wondering why ember init (or whatever other step in the upgrade CLI process it was) caused such a significant diff in my package.json and bower.json. @stefanpenner @twokul TIA.

@kellyselden
Copy link
Member

@lrsnider ember init is not a perfect tool, it just resets your app state to the default. If you have a complex app, you can use diffs in the changelog (ie ember-cli/ember-new-output@v2.7.0...v2.8.0) to fine tune your upgrade (it's how I do it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants