-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow live-reload to be disabled from command line. #510
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
"ember": "./bin/ember" | ||
}, | ||
"scripts": { | ||
"test": "mocha --timeout 8000 --reporter spec tests/**/*-test.js tests/**/*/*-test.js tests/**/*-slow.js", | ||
"test": "mocha --timeout 8000 --reporter spec tests/**/*-test.js tests/**/*/*-test.js tests/**/*/*/*-test.js tests/**/*-slow.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems dumb, but without adding a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you're using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am running There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MajorBreakfast - FYI There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is super strange... o.O There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, but that is how mocha apparently works. Somewhat related: http://blog.zackehh.com/starting-mocha-tests-programmically-runner-js/ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've already though about creating a var mocha = ...;
globSync('**/*-test.js')(require); There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But mocha depends on glob. It shouldn't mess up in the first place... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should open a speparate issue for this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, I figured you were working up the PR already 😃 |
||
"autotest": "mocha --watch --reporter spec tests/**/*-test.js" | ||
}, | ||
"repository": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
'use strict'; | ||
|
||
var assert = require('../../../helpers/assert'); | ||
var liveReloadServer = require('../../../../lib/tasks/server/livereload-server'); | ||
|
||
describe('livereload-server', function() { | ||
it('should return immediately if `liveReload` option is false', function() { | ||
return liveReloadServer.start({liveReload: false}) | ||
.then(function(result) { | ||
assert.equal('live-reload is disabled', result); | ||
}); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks exotic. But if it makes @twokul happy...
Enabled: resolves to
undefined
Disabled: resolves to a
String
^^' yah...