This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Fix compatibility with Ember CLI 0.2.7 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked in ember-cli 1.13.x, but not in <= 0.2.7.
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Jul 13, 2015
Fix compatibility with Ember CLI 0.2.7
|
@dgeb - Can you publish? |
|
@blimmer thanks! Published v0.9.1 |
Turbo87
pushed a commit
that referenced
this pull request
Oct 17, 2018
Bumps [ember-cli-inject-live-reload](https://github.com/rwjblue/ember-cli-inject-live-reload) from 1.8.2 to 2.0.1. <details> <summary>Changelog</summary> *Sourced from [ember-cli-inject-live-reload's changelog](https://github.com/ember-cli/ember-cli-inject-live-reload/blob/master/CHANGELOG.md).* > ## v2.0.1 (2018-10-15) > > #### 🐛 Bug Fix > * [#66](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/66) Update minimum ember-cli version for scoped path ([[**rwjblue**](https://github.com/rwjblue)](https://github.com/rwjblue)) > * [#65](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/65) fix: syntax error in `dynamicScript` ([[**buschtoens**](https://github.com/buschtoens)](https://github.com/buschtoens)) > > #### Committers: 2 > - Jan Buschtöns ([[**buschtoens**](https://github.com/buschtoens)](https://github.com/buschtoens)) > - Robert Jackson ([[**rwjblue**](https://github.com/rwjblue)](https://github.com/rwjblue)) > > ## v2.0.0 (2018-10-15) > > #### 💥 Breaking Change > * [#60](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/60) Drop support for Node 4 ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87)) > > #### Committers: 1 > - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87)) > > ## v1.10.1 (2018-10-13) > > #### 🚀 Enhancement > * [#59](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/59) package.json: Declare Node.js version requirements. ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87)) > > #### 🐛 Bug Fix > * [#58](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/58) Run test suite on TravisCI and fix Node 4 compatibility. ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87)) > > #### 🏠 Internal > * [#57](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/57) Add linting via ESLint. ([[**rwjblue**](https://github.com/rwjblue)](https://github.com/rwjblue)) > > #### Committers: 2 > - Robert Jackson ([rwjblue](https://github.com/rwjblue)) > - Tobias Bieniek ([Turbo87](https://github.com/Turbo87)) > > > ## v1.10.0 (2018-10-13) > > #### 🐛 Bug Fix > * [#55](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/55) Pass path as argument to livereload.js ([[**SparshithNR**](https://github.com/SparshithNR)](https://github.com/SparshithNR)) > > #### 🏠 Internal > * [#54](https://github-redirect.dependabot.com/ember-cli/ember-cli-inject-live-reload/pull/54) Refactoring and Tests ([[**SparshithNR**](https://github.com/SparshithNR)](https://github.com/SparshithNR)) > > #### Committers: 1 > - SparshithNRai ([[**SparshithNR**](https://github.com/SparshithNR)](https://github.com/SparshithNR)) </details> <details> <summary>Commits</summary> - [`6177d46`](ember-cli/ember-cli-inject-live-reload@6177d46) 2.0.1 - [`f921618`](ember-cli/ember-cli-inject-live-reload@f921618) Add v2.0.1 to CHANGELOG. - [`09f1525`](ember-cli/ember-cli-inject-live-reload@09f1525) Merge pull request [#66](https://github-redirect.dependabot.com/rwjblue/ember-cli-inject-live-reload/issues/66) from ember-cli/require-ember-cli-3-5-1 - [`ace5a8d`](ember-cli/ember-cli-inject-live-reload@ace5a8d) Update minimum ember-cli version for scoped path - [`2e279ff`](ember-cli/ember-cli-inject-live-reload@2e279ff) Merge pull request [#65](https://github-redirect.dependabot.com/rwjblue/ember-cli-inject-live-reload/issues/65) from buschtoens/patch-1 - [`a5f3062`](ember-cli/ember-cli-inject-live-reload@a5f3062) Restructure test harness to actually evaluate script. - [`5bab3c2`](ember-cli/ember-cli-inject-live-reload@5bab3c2) fix: add empty string in `dynamicScript` - [`7f5ffad`](ember-cli/ember-cli-inject-live-reload@7f5ffad) fix: syntax error in `dynamicScript` - [`21a7005`](ember-cli/ember-cli-inject-live-reload@21a7005) 2.0.0 - [`e754721`](ember-cli/ember-cli-inject-live-reload@e754721) Add v2.0.0 to CHANGELOG.md. - Additional commits viewable in [compare view](rwjblue/ember-cli-inject-live-reload@v1.8.2...v2.0.1) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=ember-cli-inject-live-reload&package-manager=npm_and_yarn&previous-version=1.8.2&new-version=2.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. Dependabot will **not** automatically merge this PR because it includes a major update to a development dependency. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the settings from the QUnit component test and tested against Ember CLI 1.13.1, but not other versions.
One of my projects uses 0.2.7 (haven't had time to upgrade yet), so this changeset allows working with 0.2.7 and 1.13.x.
I bumped this version to 0.9.1.