fixes #46 - Warns on usage of Qunit which clashes with Mocha tests. #47
Conversation
| @@ -76,6 +76,13 @@ module.exports = { | |||
| this.jshintrc = app.options.jshintrc; | |||
| }, | |||
|
|
|||
| postBuild: function () { | |||
There was a problem hiding this comment.
I thought that but I was getting init called twice, unless you are happy with me exiting after error?
There was a problem hiding this comment.
I think that having both ember-cli-qunit AND ember-cli-mocha is an error condition and continuing is unlikely to go well...
We can also remove ember-cli-qunit in the blueprint to make this even more unusual of a case...
There was a problem hiding this comment.
Cool happy with both of those suggestions.
Am I right in thinking there is no current API for removing packages?
There was a problem hiding this comment.
yes, I do not think one exists, but I'm not opposed to it either...
There was a problem hiding this comment.
Cool, that is something I have wanted for this exact use-case so happy you are on board. I see the task exists so will look into it.
There was a problem hiding this comment.
Also in init with a process.exit(1); causes it to not be able to be installed in the first place.
jonathanKingston
force-pushed
the
warn-on-qunit-usage
branch
from
e7aff05 to
46c3a03
Compare
|
Doesn't depend upon ember-cli/ember-cli#3841 but certainly would be better to go with it. |
|
@rwjblue API added, however I am considering creating a RFC for removePackageFromProject too which calls a 'uninstall' hook so that for example qunit can clean itself up when ember-cli-mocha wants it's removal. |
|
@jonathanKingston this looks great - thanks for your work here and in ember-cli! This seems ready to merge at this point (because of the check for |
|
@dgeb this could merge certainly as you say because it checks if it can run; however I think my suggestion of a Thanks |
|
@dgeb RFC raised: ember-cli/rfcs#13 Thanks |
fixes #46 - Warns on usage of Qunit which clashes with Mocha tests.
|
@jonathanKingston thank you! Let's see where that RFC goes and refine our approach as possible. |
|
👍 thanks @dgeb |
No description provided.