Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Split "chai" code into "ember-cli-chai" addon #143

Merged
merged 1 commit into from
Nov 25, 2016
Merged

Split "chai" code into "ember-cli-chai" addon #143

merged 1 commit into from
Nov 25, 2016

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 25, 2016

@Turbo87 Turbo87 merged commit b21ddf0 into ember-cli:master Nov 25, 2016
@Turbo87
Copy link
Member Author

Turbo87 commented Nov 25, 2016

thanks @rwjblue

@Turbo87 Turbo87 deleted the chai branch November 25, 2016 16:38
@Turbo87
Copy link
Member Author

Turbo87 commented Nov 25, 2016

@rwjblue eventually I'd like to move the ember-cli-chai dependency into the default blueprint so that users can decide for themselves which version they want to use (chai 4.0 will be released soon with a few breaking changes)

@rwjblue
Copy link
Member

rwjblue commented Nov 25, 2016

Right, makes sense

@alexlafroscia
Copy link
Contributor

Looks good to me, too!

@Turbo87 Turbo87 mentioned this pull request Nov 26, 2016
Merged
@Turbo87 Turbo87 added this to the v0.13.0 milestone Nov 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @rwjblue @alexlafroscia