Add a test that covers addon templates and fix ember-try to include correct ember-cli versions #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
commented
Sep 2, 2022
mansona
force-pushed
the
ember-cli-test
branch
from
5cbc183 to
1b9e019
Compare
ef4
approved these changes
Sep 8, 2022
|
Released in 6.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least shows the problem described in #754 and gives us a failing test to work with 👍Edit: I paired with @ef4 today and we figured out the right incantation to get this to work 🎉 😂
This PR is now ready for review 👍
Fixes #754