Revert "Bump semver from 6.3.0 to 7.0.0" #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c62ef6. **_tldr;_** `semver@7.x` _arguably_ includes breaking changes in a minor release (from 7.0.0 to 7.1.0), and we cannot update to 7.x until ember-cli-htmlbars drops Node 8 support. At the time the `semver@7.0.0` version bump (from 1c62ef6) landed the CHANGELOG.md for `semver@7.0.0` stated: * Refactor module into separate files for better tree-shaking * Drop support for very old node versions, use const/let, => functions, and classes. The verbiage here is obviously imprecise, and when merging (and releasing) I misinterpretted "very old node versions" as being versions older than Node 4.0.0 (in other words, versions that didn't support the features stated immediately following). Unfortunately, semver changed their `engines` version _after_ 7.0.0 was released (included in the 7.1.0 release) to only allow Node 10 or higher (see [here](npm/node-semver@d61f828)). Unfortunately, due to the way `yarn` works by default, this change in `engines` is actually a breaking change for `yarn` users (unless they specify the `--ignore-engines` flag).
locks
approved these changes
Jan 15, 2020
Turbo87
approved these changes
Jan 15, 2020
|
Released in 4.2.2 https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1c62ef6.
tldr;
semver@7.xarguably includes breaking changes in a minor release (from 7.0.0 to 7.1.0), and we cannot update to 7.x until ember-cli-htmlbars drops Node 8 support.At the time the
semver@7.0.0version bump (from 1c62ef6) landed the CHANGELOG.md forsemver@7.0.0stated:The verbiage here is obviously imprecise, and when merging (and releasing) I misinterpretted "very old node versions" as being versions older than Node 4.0.0 (in other words, versions that didn't support the features stated immediately following). Unfortunately, semver changed their
enginesversion after 7.0.0 was released (included in the 7.1.0 release) to only allow Node 10 or higher (see here). Unfortunately, due to the wayyarnworks by default, this change inenginesis actually a breaking change foryarnusers (unless they specify the--ignore-enginesflag).