Refactor implementation of colocation feature. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
reviewed
Sep 7, 2019
chancancode
reviewed
Sep 7, 2019
colocated-broccoli-plugin.js
Outdated
| if (!jsContents.includes('export default')) { | ||
| let message = `\`${filePath}\` does not contain a \`default export\`. Did you forget to export the component class?`; | ||
| return `${jsContents}\nthrow new Error(${JSON.stringify(message)});`; | ||
| } |
There was a problem hiding this comment.
We can probably move this check/rewrite to the babel plugin now, for fewer false positives.
chancancode
reviewed
Sep 7, 2019
|
FYI - This is a prototype of the AST transform: |
Makes testing easier (at least it makes my mental overhead somewhat less while testing 😀)
rwjblue
force-pushed
the
colocation-refactor
branch
from
344f079 to
01ec661
Compare
rwjblue
force-pushed
the
colocation-refactor
branch
from
01ec661 to
5709c0f
Compare
This will be done by an AST plugin instead.
rwjblue
force-pushed
the
colocation-refactor
branch
from
a34be12 to
9362a4c
Compare
No need to require / load build related things when not building...
rwjblue
force-pushed
the
colocation-refactor
branch
from
3ae00df to
99ac97d
Compare
chancancode
reviewed
Sep 12, 2019
| const __COLOCATED_TEMPLATE__ = hbs\`{{yield}}\`; | ||
| import templateOnly from '@ember/component/template-only'; | ||
|
|
||
| export default templateOnly();` + '\n', |
There was a problem hiding this comment.
I just realized we made this function take a string for the moduleName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hbs(still WIP)Note: This targets the
colocationbranch (so that we can avoid breaking folks actively using the@ember/octane-app-blueprintwhich uses thecolocationbranch).