Merge pull request #675 from alexlafroscia/fix-release-it-dep

ember-cli · Mar 4, 2021 · f000b33 · f000b33
2 parents c073888 + 3d772dd
commit f000b33
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,7 +20,7 @@ jobs:
       with:
         node-version: 12.x
     - name: install dependencies
-      run: yarn install
+      run: yarn install --frozen-lockfile
     - name: lint:js
       run: yarn lint:js
     - name: lint:hbs
@@ -41,7 +41,7 @@ jobs:
       with:
         node-version: ${{ matrix.node-version }}
     - name: install dependencies
-      run: yarn install
+      run: yarn install --ignore-engines --frozen-lockfile
     - name: node tests
       run: yarn test:node
     - name: ember test

diff --git a/package.json b/package.json
@@ -91,9 +91,7 @@
     "mocha": "^8.3.0",
     "module-name-inliner": "link:./tests/dummy/lib/module-name-inliner",
     "prettier": "^2.2.1",
-    "qunit-dom": "^1.6.0"
-  },
-  "optionalDependencies": {
+    "qunit-dom": "^1.6.0",
     "release-it": "^14.2.1",
     "release-it-lerna-changelog": "^3.1.0"
   },