Limit logging #93
Limit logging #93
Conversation
| let secondExpected = `DEPRECATION: ${secondMessage}`; | ||
|
|
||
| let secondCount = 0; | ||
| window.Testem.handleConsoleMessage = function (passedMessage) { |
There was a problem hiding this comment.
Is this torn down by testem after each test? I've not used it before. It seems like it would leak between tests?
There was a problem hiding this comment.
I’m not sure. I just copied the prior test assuming it did the right thing.
There was a problem hiding this comment.
Seems like it is handled in the before/after callbacks above
There was a problem hiding this comment.
oh is this a thing? There are so many logs I would like to silence that aren't even deprecation related. I wish testem would always just not-print logs by default. in CI.
|
@mixonic can we get this merged? |
|
@wagenet - perhaps make the log limit configurable? |
|
@boris-petrov I'm not opposed to that, but I also don't see it being a necessity either. 100 should be far more than enough and resolve the problem of the runner hanging due to thousands of messages. |
|
Exactly - 100 may be much more than someone's preference. :) |
|
Yeah, my concern was less about preference and more about making sure the runner doesn't crash! |
mixonic
added
the
2.0
Limits console log to avoid causing ember server to hang which can happen if there is too much logging.