Remove @ember/string (it's unused) #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Aug 21, 2024
package.json
Outdated
| @@ -101,5 +100,6 @@ | |||
| "ember-addon": { | |||
| "configPath": "tests/dummy/config", | |||
| "after": "ember-cli-htmlbars" | |||
| } | |||
| }, | |||
| "packageManager": "pnpm@9.6.0+sha512.38dc6fba8dba35b39340b9700112c2fe1e12f10b17134715a4aa98ccf7bb035e76fd981cf0bb384dfa98f8d6af5481c2bef2f4266a24bfa20c34eb7147ce0b5e" | |||
There was a problem hiding this comment.
this is added with newer versions of pnpm.
As-is, there is nothing in the repo saying which pnpm version to use.
CI says to use version 8 -- so I'll downgrade, set this, and set a volta config.
SergeAstapov
approved these changes
Aug 21, 2024
kategengler
reviewed
Aug 21, 2024
| @@ -101,5 +100,10 @@ | |||
| "ember-addon": { | |||
| "configPath": "tests/dummy/config", | |||
| "after": "ember-cli-htmlbars" | |||
| }, | |||
| "packageManager": "pnpm@8.15.9", | |||
| "volta": { | |||
There was a problem hiding this comment.
it only matters for folks who have volta installed locally, and affects no one and nothing else
There was a problem hiding this comment.
I set the tool versions to what CI is using
kategengler
approved these changes
Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #194