Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start using pnpm #188

Merged
merged 2 commits into from
Jun 25, 2024
Merged

start using pnpm #188

merged 2 commits into from
Jun 25, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Jun 24, 2024

No description provided.

@mansona mansona force-pushed the pnpm branch 3 times, most recently from 7133c5f to f41ca55 Compare June 24, 2024 15:41
@mansona mansona requested a review from NullVoxPopuli June 24, 2024 15:42
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use pnpm 9

@mansona
Copy link
Member Author

mansona commented Jun 25, 2024

we discussed this in the Tooling team and it turns out that the PR was wrong, but not because of the pnpm version. I dropped the node version that CI was using to the same that was in volta before this PR 👍

@mansona mansona merged commit 3b160db into main Jun 25, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants