This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Accept multiple input nodes #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangm
commented
Nov 29, 2017
| return nodesIncludesOverrides.some(Boolean); | ||
| } | ||
|
|
||
| return nodeIncludesOverrides(sourceDirectory, eslintCli); |
There was a problem hiding this comment.
This is a bit questionable, mostly due to my lack of knowledge in Broccoli.
I feel it's safer to do
if (nodeType === 'transform') {
...
} else if (nodeType === 'source') {
...
}
return false
Let me know
sangm
force-pushed
the
multiple-nodes
branch
from
a21624f to
8b3f219
Compare
Turbo87
reviewed
Feb 17, 2018
lib/index.js
Outdated
| EslintValidationFilter.prototype.processString = function processString( | ||
| content, | ||
| relativePath | ||
| ) { |
There was a problem hiding this comment.
can you remove the irrelevant formatting changes from this PR? that would make it much easier to review 🤔
There was a problem hiding this comment.
I can. Do you mind if I apply the formatting changes as a separate commit? (Just prettier's default since emacs is already hooked up)
Or do you wish to not see them entirely?
There was a problem hiding this comment.
I'd prefer it if they were a separate PR, with a separate discussion
|
@Turbo87 sorry it took so long, I updated the PR without prettier. |
|
I think this issue is causing a blocking issue with module unification Ember apps/addons merging trees with |
Turbo87
pushed a commit
that referenced
this pull request
Oct 19, 2018
Bumps [sinon-chai](https://github.com/domenic/sinon-chai) from 2.14.0 to 3.2.0. <details> <summary>Release notes</summary> *Sourced from [sinon-chai's releases](https://github.com/domenic/sinon-chai/releases).* > ## 3.2.0 > Added support for Sinon v6.x. ([**mattbaileyuk**](https://github.com/mattbaileyuk), [#127](https://github-redirect.dependabot.com/domenic/sinon-chai/issues/127)) > > ## 3.1.0 > Added support for Sinon v5.x. ([**dostu**](https://github.com/dostu), [#122](https://github-redirect.dependabot.com/domenic/sinon-chai/issues/122)) > > Added `calledOnceWith` and `calledOnceWithExactly` matchers. ([**JayAndCatchFire**](https://github.com/JayAndCatchFire), [#117](https://github-redirect.dependabot.com/domenic/sinon-chai/issues/117)) > > ## 3.0.0 > * Required Node.js version 4 or later > * Required Sinon version 4 or later > * Required Chai version 4 or later </details> <details> <summary>Commits</summary> - [`ee154c9`](chaijs/sinon-chai@ee154c9) 3.2.0 - [`629ca2e`](chaijs/sinon-chai@629ca2e) Add support for Sinon v6 - [`7e6bdae`](chaijs/sinon-chai@7e6bdae) 3.1.0 - [`7a54718`](chaijs/sinon-chai@7a54718) Go back to testing Node v4 + stable - [`9fa3b07`](chaijs/sinon-chai@9fa3b07) Add calledOnceWith and calledOnceWithExactly - [`293401a`](chaijs/sinon-chai@293401a) Add support for sinon v5 - [`31ec838`](chaijs/sinon-chai@31ec838) 3.0.0 - [`9021278`](chaijs/sinon-chai@9021278) Reduce the support matrix - [`baf4a43`](chaijs/sinon-chai@baf4a43) Fix incorrect example in README.md - See full diff in [compare view](chaijs/sinon-chai@v2.14.0...v3.2.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=sinon-chai&package-manager=npm_and_yarn&previous-version=2.14.0&new-version=3.2.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. Dependabot will **not** automatically merge this PR because it includes a major update to a development dependency. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on merging test trees with in repo addons. ember-addon-in-repo-tests
I'm running into issues where
broccoli-lint-eslintcannot handle multiple nodes. @rwjblue suggested if theeslintrcincludesoverridesflag, we can ignore this check.