Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide session token to credentials #192

Merged

Conversation

bobisjan
Copy link
Contributor

This is a followup to #190, where accessKeyId and secretAccessKey were moved to the credentials object.

The optional sessionToken is also part of credentials object in AWS SDK v3.

Fixes The AWS Access Key Id you provided does not exist in our records. error when using session token from STS service.

@bobisjan
Copy link
Contributor Author

@lukemelia 👋, can you please take a look?

@IvanVlasic
Copy link

IvanVlasic commented Jan 31, 2025

Hello @lukemelia,

can this please be merged?

Without this, using STS for credentials is completely broken, which is a significant issue if we want to follow best security practices and move away from using IAM users.

Thanks.

@lukemelia lukemelia merged commit 7774d21 into ember-cli-deploy:master Jan 31, 2025
@IvanVlasic
Copy link

@lukemelia thank you very much for quick merge!

Would you also release a new version with this fix so we can use it in our project? I've tested the fix and it works as expected.

Thank you!

@bobisjan
Copy link
Contributor Author

bobisjan commented Feb 2, 2025

@lukemelia thanks for merge 🥳, I agree with @IvanVlasic, that this is a bugfix instead of enhancement, because using STS worked well before migration to AWS SDK v3, where the bug was introduced.

@bobisjan bobisjan deleted the credentials-session-token branch February 2, 2025 13:01
@lukemelia lukemelia added bug and removed enhancement labels Feb 2, 2025
@lukemelia
Copy link
Contributor

Released as v5.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants