Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding embroider tests to testing metrics #741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiwiupover
Copy link

@kiwiupover kiwiupover commented Jun 23, 2020

ember-cli-addon-docs need to be deployed
ember-learn/ember-cli-addon-docs#474

After ember-cli-addon-docs are updated the next errors.

@ef4 when testing with embroider it looks like a few addons are including @babel/plugin-proposal-optional-chaining
Resolving to a single version in the package.json does not fix the issue.

ERROR Summary:
  - broccoliBuilderErrorStack: ModuleBuildError: Module build failed (from /Users/kiwi/projects/ember-app-scheduler/node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
Duplicate plugin/preset detected.
If you'd like to use two separate instances of a plugin,
they need separate names, e.g.

  plugins: [
    ['some-plugin', {}],
    ['some-plugin', {}, 'some unique name'],
  ]

Duplicates detected are:
[
  {
    "alias": "/Users/kiwi/projects/ember-app-scheduler/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
    "dirname": "/Users/kiwi/projects/ember-app-scheduler",
    "ownPass": false,
    "file": {
      "request": "/Users/kiwi/projects/ember-app-scheduler/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
      "resolved": "/Users/kiwi/projects/ember-app-scheduler/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js"
    }
  },
  {
    "alias": "/Users/kiwi/projects/ember-app-scheduler/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
    "dirname": "/Users/kiwi/projects/ember-app-scheduler",
    "ownPass": false,
    "file": {
      "request": "/Users/kiwi/projects/ember-app-scheduler/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
      "resolved": "/Users/kiwi/projects/ember-app-scheduler/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js"
    }
  }
]

@ef4
Copy link

ef4 commented Jun 23, 2020

I think this is the same issue as embroider-build/embroider#453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants