Apply visibility by clearing the property. #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. To test this, if you can add a route under /scenarios that demonstrates the problem interactively, I can help show how to write an automated test for it. |
brettburley
force-pushed
the
fix-visibility
branch
from
c00b662
to
73c9968
Compare
`visibility: visible;` and `visibility:;` have different behaviors -- the former is visible even if a parent container has a `visibility: hidden;`. As a result, if there are nested animated containers, and a parent container uses the explode transition, there will be a ghost of the children that have `visibility: visible` applied since the transition relies on cloning the DOM.
brettburley
force-pushed
the
fix-visibility
branch
from
73c9968
to
2eeb466
Compare
|
Thanks @ef4, I totally missed the scenarios tests. I took a stab at writing one -- please take a look and provide any feedback or suggestions you have, thanks! |
|
Looks nice, thanks again. |
|
This PR may have caused a regression, haven't had a chance to dig into the details yet: #610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address #606.
visibility: visible;andvisibility: ;have different behaviors -- the former is visible even if a parent container has avisibility: hidden;. As a result, if there are nested animated containers, and a parent container uses the explode transition, there will be a ghost of the children that havevisibility: visibleapplied since the transition relies on cloning the DOM.Suggestions welcome on how this might be able to be tested.