Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slf4j-reload4j to 2.0.9 #466

Merged

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates org.slf4j:slf4j-reload4j from 1.7.36 to 2.0.9

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.slf4j", artifactId = "slf4j-reload4j" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.slf4j", artifactId = "slf4j-reload4j" }
}]
labels: test-library-update, early-semver-major, semver-spec-major, commit-count:1

@mergify mergify bot merged commit 6f666de into embeddedkafka:master Sep 7, 2023
@francescopellegrini
Copy link
Collaborator

@guizmaii are you confident this won't break anything? I was very reluctant because of the major bump...

@guizmaii
Copy link
Contributor

guizmaii commented Sep 7, 2023

are you confident this won't break anything?

Hum no, I'm not. I guess we'll see if it breaks something later when we'll release a new version and people will complain

@francescopellegrini
Copy link
Collaborator

are you confident this won't break anything?

Hum no, I'm not. I guess we'll see if it breaks something later when we'll release a new version and people will complain

I'd rather roll it back, actually, if we're not confident about it :/

@guizmaii
Copy link
Contributor

guizmaii commented Sep 7, 2023

Which version of slf4j is Kafka using?

Edit:
1.7.36 apparently: https://github.com/apache/kafka/blob/3.5/gradle/dependencies.gradle#L124C3-L124C8
So yeah, we probably need to rollback. I'll do it. Thanks for your carefulness

Edit2: See #467

guizmaii added a commit that referenced this pull request Sep 7, 2023
guizmaii added a commit that referenced this pull request Sep 7, 2023
@scala-steward scala-steward deleted the update/slf4j-reload4j-2.0.9 branch September 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants