build(deps): bump web3[-*] from 1.2.1 to 1.2.4 #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor typings as necessary. In order for `bignumber.js` in the root `node_modules` to not conflict with `@types/bignumber.js`, specify `"bignumber.js": "5.0.0"` in `devDependencies` and `"embark-ui/bignumber.js"` in `nohoist` of the root `package.json`. In `packages/plugins/rpc-manager` switch from callback to promise usage with respect to `web3.eth.accounts.signTransaction` because of a [bug][bug] discovered in web3 v1.2.4. In `packages/plugins/solidity-tests` specialize the tsc compiler options with `"skipLibCheck": true` because of a problematic web3-related typing in the `.d.ts` files of the remix-tests package. Bump ganache-cli from 6.4.3 to 6.7.0 (latest) because 6.4.3 doesn't support `eth_chainId` but web3 1.2.4 makes use of the `eth_chainId` RPC method (EIP 695). BREAKING CHANGE: bump embark's minimum supported version of parity from `>=2.0.0` to `>=2.2.1`. This is necessary since web3 1.2.4 makes use of the `eth_chainId` RPC method (EIP 695) and that parity version is the earliest one to implement it. [bug]: web3/web3.js#3283
DeepCode's analysis on #2c6e98 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 2, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L296-L299 * https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298 The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the return value using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 2, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L296-L299](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L296-L299) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the return value using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 2, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the return value using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 2, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the return value's type using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 3, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the return value's type using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 3, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web3 v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the resolved return value's type using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 3, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web3 v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the resolved return value's type using TypeScript's `as` operator.
michaelsbradleyjr
added a commit
that referenced
this pull request
Feb 3, 2020
Remove `bignumber.js` workaround (in the root, from PR #2152) because it's no longer needed (verified locally). Remove the `"skipLibCheck"` workaround (in `packages/plugins/solidity-tests`, from PR #2152) because it's no longer needed (verified locally). Refactor a typing in `packages/plugins/geth`. What's happening is that in web3 v1.2.4 `sendTransaction` has a return type of `PromiEvent<TransactionReceipt>` but in v1.2.6 it has a return type of `PromiEvent<TransactionReceipt | TransactionRevertInstructionError>`. Compare: * [v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294](https://github.com/ethereum/web3.js/blob/v1.2.4/packages/web3-eth/types/index.d.ts#L291-L294) * [v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298](https://github.com/ethereum/web3.js/blob/v1.2.6/packages/web3-eth/types/index.d.ts#L295-L298) The problem is that the `TransactionRevertInstructionError` type doesn't have a `transactionHash` property. Since at present the code in `packages/plugins/geth/src/devtxs.ts` only deals with the success case re: `sendTransaction`, import the `TransactionReceipt` type from `web3-eth` and cast the resolved return value's type using TypeScript's `as` operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is similar to #2142 but is against the
masterbranch, i.e. it’s for the forthcoming embark v5.Refactor typings as necessary. In order for
bignumber.jsin the rootnode_modulesto not conflict with@types/bignumber.js, specify"bignumber.js": "5.0.0"indevDependenciesand"embark-ui/bignumber.js"innohoistof the rootpackage.json.In
packages/plugins/rpc-managerswitch from callback to promise usage with respect toweb3.eth.accounts.signTransactionbecause of a bug discovered in web3 v1.2.4.In
packages/plugins/solidity-testsspecialize the tsc compiler options with"skipLibCheck": truebecause of a problematic web3-related typing in the.d.tsfiles of the remix-tests package.Bump ganache-cli from 6.4.3 to 6.7.0 (latest) because 6.4.3 doesn't support
eth_chainIdbut web3 1.2.4 makes use of theeth_chainIdRPC method (EIP 695).BREAKING CHANGE: bump embark's minimum supported version of parity from
>=2.0.0to>=2.2.1. This is necessary since web3 1.2.4 makes use of theeth_chainIdRPC method (EIP 695) and that parity version is the earliest one to implement it.