fix: adjust module resolution behavior #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsbradleyjr
force-pushed
the
fix/module-resolution
branch
from
dfddf8b to
b60ad15
Compare
|
Safari browser on macOS is unable to connect with websocket with these changes in place. The reason is unknown at this time, and it may be related to a bug/s in web3 beta.34. |
alaibe
approved these changes
Dec 3, 2018
jrainville
approved these changes
Dec 3, 2018
|
@jrainville yes, the user would need to re-eject and re-customize |
michaelsbradleyjr
force-pushed
the
fix/module-resolution
branch
2 times, most recently
from
1c2a0fa to
8ac173d
Compare
|
Ok, yeah. |
|
Good idea! |
michaelsbradleyjr
force-pushed
the
fix/module-resolution
branch
from
8ac173d to
3ee3e86
Compare
michaelsbradleyjr
force-pushed
the
master
branch
from
73d5a72 to
f10e025
Compare
Include yarn's global path when modifying `NODE_PATH` since dependencies are
deduped when a package is installed globally with yarn, which is different from
npm's behavior.
Fix webpack resolution by listing relative `'node_modules'` in
`resolve/Loader:{modules:[...]}`. This ensures that dependecies' dependecies
are resolved correctly when webpack builds a DApp.
Remove the invocation of `.catch()` on a subscription object which lacks that
method.
michaelsbradleyjr
force-pushed
the
fix/module-resolution
branch
from
3ee3e86 to
4c39452
Compare
emizzle
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include yarn's global path when modifying
NODE_PATHsince dependencies are deduped when a package is installed globally with yarn, which is different from npm's behavior.Fix webpack resolution by listing relative
'node_modules'inresolve/Loader:{modules:[...]}. This ensures that dependecies' dependecies are resolved correctly when webpack builds a DApp.Remove the invocation of
.catch()on a subscription object which lacks that method.