lsp-ui-doc-glance auto-hide is not triggering
#695
Labels
Comments
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
Apr 6, 2022
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
Apr 6, 2022
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
Apr 12, 2022
|
I agree with you. Even though I rarely see the issue from the current implementation! 😅 Thanks for the changes! |
jcs090218
pushed a commit
that referenced
this issue
May 9, 2022
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
May 15, 2022
Fixes emacs-lsp#695 For some inexplicable reason, `lsp-ui-doc-show` calls `lsp-ui-doc--callback` synchronously, while `lsp-ui-doc-glance` went via a more tortuous asynchronous route (via `lsp-ui-doc--make-request`). This commit makes `lsp-ui-doc-glance` equivalent to calling `lsp-ui-doc-show` followed by *delayed* addition to `post-command-hook` (since we're already in a command) of the `lsp-ui-doc--glance-hide-frame` function. Note that `lsp-ui-doc--glance-hide-frame` is also simplified to just remove itself from `post-command-hook` and directly call `lsp-ui-doc-hide`.
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
May 15, 2022
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
May 15, 2022
Lenbok
added a commit
to Lenbok/lsp-ui
that referenced
this issue
May 15, 2022
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for this function says that the documentation will automatically hide on next typing, however this does not happen, in my experience.
Perhaps my reading of the code is wrong, but it seems the mechanism for clearing is unreliable, in that the clearing of the doc is triggered via
post-command-hookbut the retrieval of the documentation from the language server happens asynchronously (i.e. it's quite likely that the documentation is returned afterlsp-ui-doc--glance-hide-framehas been removed frompost-command-hook, which would lead to the documentation persisting).I also put a
messageat the start oflsp-ui-doc--glance-hide-frameand it seems to be called immediately, rather than after the next command. Does adding a function to post-command-hook while a command is currently executing result in that function being called when the current command finishes executing? If so, this also seems like the wrong behaviour.It seems that the addition of
lsp-ui-doc--glance-hide-frametopost-command-hookshould instead happen once the documentation is returned from the server.Edit: the bug only affects inline doc display mode.
The text was updated successfully, but these errors were encountered: