-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): use npm i-peers
instead of npm-install-peers
#4711
base: master
Are you sure you want to change the base?
Conversation
cc @elken |
Seems to work fine using https://github.com/privatenumber/i-peers instead. Don't know why it suddenly stopped working. In this case they've finally put graphql as a dev dependency, but this is still needed to handle other cases where deps are incorrectly placed in peerDeps and not in devDeps. |
From looking at the commits, I thought the installation of peer was added for graphql, so I thought it was rather unnecessary in the current situation where graphql would not work. Do you know of any other servers that specifically depend on the PEER installation to run? |
As I said in my first message, I've already linked a package that works. There really doesn't need to be a massive debate here. |
Indeed, if there is something that works, it is reasonable to use it in a straightforward manner. |
236e1f2
to
db5a403
Compare
I thought about creating a new PR, but I thought it would be too much trouble to follow the history of how it happened, so I rewrote it to use the package pointed out in this PR. |
npm i-peers
instead of npm-install-peers
When I run `npm-install-peers` in the `graphql-language-service-cli` directory, oddly enough, the `graphql-language-service` disappears from `node_modules` as a result of dependency resolution. As a result, the graphql language server does not work at all. From the PR I linked to, it seems that the mechanism to run `npm-install-peers` was originally put in for graphql. [Pull npm peerDependencies as required by elken · Pull Request emacs-lsp#3511 · emacs-lsp/lsp-mode](emacs-lsp#3511) Maybe if it was a previous version, it would rather not work without installing it. Replaced with a working package. I honestly don't know why `npm-install-peers` removes existing packages when dependency conflicts occur.
db5a403
to
5a3144d
Compare
Much appreciated. Thank you for bringing this to our attention! 😄 |
When I run
npm-install-peers
in thegraphql-language-service-cli
directory,oddly enough, the
graphql-language-service
disappears fromnode_modules
as a result of dependency resolution.As a result, the graphql language server does not work at all.
From the PR I linked to, it seems that the mechanism to run
npm-install-peers
was originally put in for graphql.Pull npm peerDependencies as required by elken · Pull Request #3511 · emacs-lsp/lsp-mode
Maybe if it was a previous version, it would rather not work without installing it.
Replaced with a working package.
I honestly don't know why
npm-install-peers
removes existing packages when dependency conflicts occur.