Implement support for textDocument/linkedEditingRange #3166
Conversation
yyoncho
force-pushed
the
linked-text-edit
branch
from
ca9f58f
to
fd34321
Compare
|
Awesome! do you have any gif or anything of some server that already implements it? |
|
xmlls implements it, I will post gif later. IMHO it will be more useful for scenarios like this eclipse-jdtls/eclipse.jdt.ls#1919 |
|
Cool, I may implement this on clojure-lsp, I just want a little spolier on the UX first :p |
|
IMHO it will look very nice for clj locals, much better experience than rename in a box. For xml we already have the tools in emacs for what you see in the gif, so it is not that special. |
|
I always wanted that @yyoncho, I'll for sure implement that on clojure-lsp :) thank you! |
|
just implemented on clojure-lsp, tested and worked perfectly @yyoncho :) |
lsp-iedit.el
Outdated
| (->> (lsp--text-document-position-params) | ||
| (lsp-request "textDocument/linkedEditingRange") | ||
| (lsp:linked-editing-ranges-ranges) | ||
| (lsp-iedit--on-ranges))) |
There was a problem hiding this comment.
Maybe we should show some feedback to user when server returns null? For example for clojure-lsp, if the element is referenced in another file, clojure-lsp returns null
There was a problem hiding this comment.
yes, that makes sense. I though that server is supposed to throw an error(which by the way will lead to a better UE because the user will know why it does not work).
There was a problem hiding this comment.
|
FYI, the function doesn't entirely work on doom-emacs: hlissner/evil-multiedit#39 (comment) because of |
yyoncho
force-pushed
the
linked-text-edit
branch
from
fd34321
to
4982564
Compare
thank you for that - now linked editing feature on lsp-mode has some value. |
yyoncho
force-pushed
the
linked-text-edit
branch
from
4982564
to
af7f5ea
Compare
yyoncho
force-pushed
the
linked-text-edit
branch
from
af7f5ea
to
ca712bc
Compare
Fixes #2449