lsp-csharp: handle interop notifications #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added by OmniSharp/omnisharp-roslyn#1911 to facilitate legacy clients (i.e. vscode) that will be transitioning to LSP.
This improves diagnostic procedure when projects cannot be loaded for some reason.
yyoncho
reviewed
Sep 20, 2020
clients/lsp-csharp.el
Outdated
| @@ -246,6 +246,11 @@ using the `textDocument/references' request." | |||
| (lsp-show-xrefs (lsp--locations-to-xref-items locations-found) nil t) | |||
| (message "No references found"))) | |||
|
|
|||
| (defun lsp-csharp--handle-os-error (_workspace params) | |||
| "Handle the 'o#/error' (interop) notification with PARAMS by displaying a message with lsp-warn." | |||
| (-let (((&hash "FileName" filename "Text" text) params)) | |||
There was a problem hiding this comment.
we should not use &hash because soon we will switch to plist for internal representation of the jsonrpc objects.
You have 2 options:
- Use lsp-get
- Define data structures and then use the getters/destructorings generated for the interface.
There was a problem hiding this comment.
done (with opt 2)
ericdallo
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handlers for '#o/XXX' notifications that have been added recently to facilitate omnisharp clients transitioning from custom to LSP protocol (see OmniSharp/omnisharp-roslyn#1911).
The events are ignored by default, except for 'o#/error' which may help resolving issues when projects are not being properly loaded (this may have helped to diagnose #2188)