Work around a bug where the tab-line isn't taken into account #115
Conversation
In Emacs before version 31, window-inside-absolute-pixel-edges returns the wrong y-offset when the per-buffer tab-line is enabled. The tab-line is taken into account when computing the window's height, so we adjust the y-offset after computing the height. Fixed upstream in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75576. * exwm-layout.el (exwm-layout--show): Adjust the window's y-offset to include the tab-line. (Bug #114)
|
It looks like Eli wants to land the patch on master (Emacs 30 is getting real close) so I've configured the check to be Emacs 30 and below. Users compiling from Emacs master will have to wait for the patch to land upstream. |
|
The issue is not that urgent. I think it is better to not delay the Emacs 30 release. For EXWM it shouldn't matter much if we check for version 30 or 31. Or are you aware of other packages or features which are broken by this? I am not sure if tab-line tabs are used widely. I've never used them in contrast to the tab-bar. |
|
I don't think this affects anyone else. I'm just waiting for a final call from the Emacs maintainers before merging this. And yeah, this absolutely should not delay the Emacs 30 release. |
|
The fix was pushed to Emacs master so I'm merging this as-is. |
In Emacs before version 31, window-inside-absolute-pixel-edges returns the wrong y-offset when the per-buffer tab-line is enabled. The tab-line is taken into account when computing the window's height, so we adjust the y-offset after computing the height.
Fixed upstream in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75576.