Adds 4 new user properties to the UserDetail check. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
|
This was tested working on Windows 10 Professional, Version 21H2. |
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
…ystem. Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
sourque
pushed a commit
that referenced
this pull request
Sep 3, 2022
* Adds 4 new user properties to the UserDetail check. Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Add modifier check type Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Updated documentation to match the "modifier" field Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Updated to ensure that users know time should be in UTC Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Removed debug lines Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Removed the modifier field and switched to a comparison value split system. Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Made comparison stricter, reducing edge cases. Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Handled more errors, optimized some code. Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Fixed error handling inversion Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * fixed documentational wording Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com> * Removed false positive Signed-off-by: Mobmaker <45888585+Mobmaker55@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
PasswordAge,BadPasswordCount,NumberOfLogons, andLastLogon, along with proper processing for either the integer count, or the date formatting.