Skip to content

Commit

Permalink
Fix e2e workflow syntax
Browse files Browse the repository at this point in the history
The workflow syntax in kubernetes-sigs#93 was incorrect, `with` is not allowed for run
steps
  • Loading branch information
elsesiy committed Oct 18, 2024
1 parent b3e7f53 commit e61f556
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ jobs:
echo "release sign test" > ${{ runner.temp }}/test-file-${{ github.run_id }}
- name: Run e2e tests
run: go run mage.go E2ETest
with:
path: ${{ runner.temp }}/test-file-${{ github.run_id }}
env:
TEST_FILE_PATH: ${{ runner.temp }}/test-file-${{ github.run_id }}
6 changes: 2 additions & 4 deletions test/e2e/sign_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func TestSignFileSuccess(t *testing.T) {
signer := testSigner(t)

// propagated by the github actions workflow
testFilePath := os.Getenv("INPUT_PATH")
testFilePath := os.Getenv("TEST_FILE_PATH")
require.NotEmpty(t, testFilePath)
signedObject, err := signer.SignFile(testFilePath)
require.NoError(t, err)
Expand All @@ -129,7 +129,5 @@ func testSigner(t *testing.T) *sign.Signer {
opts.CertIdentityRegexp = "https://github.com/kubernetes-sigs/release-sdk/.github/workflows/e2e.yml@.*"
opts.CertOidcIssuer = "https://token.actions.githubusercontent.com"

signer := sign.New(opts)

return signer
return sign.New(opts)
}

0 comments on commit e61f556

Please sign in to comment.