Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up chores #92

Merged
merged 29 commits into from
Aug 21, 2024
Merged

Tidy up chores #92

merged 29 commits into from
Aug 21, 2024

Conversation

PabRod
Copy link
Contributor

@PabRod PabRod commented Aug 21, 2024 •
edited
Loading

  • Collect all plotting functions in R/plots.R
  • Decide which plotting functions stay, and test those
  • Remove unused plotting files and functions
  • check.R -> checks.R

mdingemanse and others added 26 commits August 19, 2024 16:12
@mdingemanse
updates: intro
94aebb4
@mdingemanse
rewrite in progress
6575ef5
@PabRod
Remove unused auxiliary functions
8090a87
@PabRod
Remove hard-coded na.rm=TRUE auxiliary functions
a0f34d1 
And use standard argument passing instead
@PabRod
Merge commit '1984bfa9dea7a8b50f1c790002bd5294da4ba7bc' into increase…
b2a4354 
…-test-cov
@mdingemanse
+ describe quality plots
c509aab
@mdingemanse
updates to Workflow part B
ed1d2b0
@mdingemanse
merge from main and fix issue with example inadvertently being executed
c72dfac 
Merge branch 'main' into user-journeys

# Conflicts:
#	vignettes/workflow.Rmd
@PabRod
Merge remote-tracking branch 'origin/user-journeys' into increase-tes…
d7c2167 
…t-cov
@PabRod
Add first plot testing with snapshot
241f63f
@PabRod
Fix bug
ddea1d6 
The snapshow image was not up to date
@PabRod
Simplify the syntax with a decorator
190b323
@PabRod
Add explanation to test-plots
92c913d 
This test suites rests heavily on expect_snapshot_file, which can be a bit complicated. It deserves an explanation
@PabRod
Merge branch 'main' into increase-test-cov
5a6208f
@PabRod
Remove artifact
6e33df4
@PabRod
Merge branch 'main' into increase-test-cov
a082a2c
@PabRod
Exclude R/convplot.R from build
f7e5e4b
@PabRod
Auto update docs
3f28019
@PabRod
Explicitly call ggproto
f1fa15a
@PabRod
Hotfix ggplot2 dependencies
3d42b7a
@PabRod
Remove inspect_language.R
59d3f02
@PabRod
Move plot_quality.R and plot_turns_tokens.R into plots.R
ddae816 
In order to keep the project tidier
@PabRod
Remove plot_turns_tokens
ad724c1
@PabRod
Rename check.R to checks.R
bac056a 
For consistency
@PabRod
Clean unused plots
9ed7868
@PabRod
Autoremove snapshot
aa50c44
@bvreede bvreede marked this pull request as ready for review August 21, 2024 12:48
bvreede added 3 commits August 21, 2024 15:07
@bvreede
fix merge conflicts
6815040 
Merge branch 'main' into increase-test-cov

# Conflicts:
#	R/plots.R
#	tests/testthat/test-plots.R
@bvreede
remove unused packages from description
c24e4dd
@bvreede
imports from ggplot should be declared when used
c6254c7
@bvreede bvreede merged commit 1de1c97 into main Aug 21, 2024
3 checks passed
@bvreede bvreede deleted the increase-test-cov branch August 21, 2024 13:27
@bvreede bvreede mentioned this pull request Aug 21, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvreede bvreede bvreede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PabRod @bvreede @mdingemanse