Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals in theme_turnPlot #109

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix globals in theme_turnPlot #109

merged 2 commits into from
Aug 26, 2024

Conversation

bvreede
Copy link
Collaborator

@bvreede bvreede commented Aug 22, 2024

Closes #104

@bvreede bvreede requested a review from PabRod August 22, 2024 10:21
@mdingemanse mdingemanse self-requested a review August 26, 2024 19:22
Copy link
Contributor

@mdingemanse mdingemanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done according to the recommendations at https://ggplot2.tidyverse.org/articles/ggplot2-in-packages.html, works locally, doesn't result in change to test plots — all good.

@mdingemanse mdingemanse merged commit 0ce5a4e into main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing/globals of themeTurnPlot
2 participants