Create validations based on maxlength attribute and create a new callback #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elo7-developer
force-pushed
the
EM-106487
branch
from
ace9c94
to
530211d
Compare
AlineLee
suggested changes
Aug 22, 2017
|
|
||
| ```html | ||
| <script src='async-define.js'></script> | ||
| <script src='events-amd.js' async></script> |
There was a problem hiding this comment.
Podia comentar que essa é uma dependência do doc-amd.
README.md
Outdated
|
|
||
| - `added(addedTags)`: called when one or more tags are added to the list of tags; receives an array with the new tags as argument | ||
| - `removed(removedTag)`: called when a tag is removed from the list; receives the removed tag as argument | ||
| - `error(tagInput)`: called when the user tries to add a tag that already exists in the list; receives the input as argument |
There was a problem hiding this comment.
O callback error não é muito genérico? Sendo que ele só trata o caso de tags que já existem? Podia renomear para: errorAlreadyExists ?
AlineLee
added
# FIX (ಥ﹏ಥ)
# FIXING ། – _ – །
and removed
# TO TEST (ಠ_ರೃ)
# FIX (ಥ﹏ಥ)
labels
AlineLee
suggested changes
Aug 22, 2017
README.md
Outdated
| npm install elo7-tag-amd | ||
| ``` | ||
|
|
||
| In the download package, there will be a JavaScript file (`tag.js`) and a CSS file (`tag.css`). The JavaScript file is not minified, but we strongly recommend minifying it before production usage. The CSS file is optional; you may use it as a reference for your own styling. |
There was a problem hiding this comment.
It has a minified version on the dist folder, how about to change this comment and generate a minified version (js and css)?
added 2 commits
August 22, 2017 16:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍 @tisvasconcelos
@luiz @tcelestino