Skip to content

Commit

Permalink
Merge pull request #5 from elo7/update-deps-button
Browse files Browse the repository at this point in the history
Change type of remove tag button to "button"
  • Loading branch information
Aline Lee authored Aug 11, 2017
2 parents a516b48 + fbd72d8 commit 07e0002
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
7 changes: 2 additions & 5 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "tag-amd",
"version": "1.1.1",
"version": "1.1.2",
"description": "Transform an input into a tag field",
"main": "tag.js",
"authors": [
Expand All @@ -22,9 +22,6 @@
"tests"
],
"dependencies": {
"doc-amd": "1.0.12"
},
"devDependencies": {
"async-define": "elo7/async-define#1.0.5"
"doc-amd": "1.1.1"
}
}
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "elo7-tag-amd",
"version": "1.1.1",
"version": "1.1.2",
"description": "Transform an input into a tag field",
"main": "tag.js",
"scripts": {
Expand All @@ -24,15 +24,15 @@
},
"homepage": "https://github.com/elo7/tag-amd#readme",
"dependencies": {
"define-async": "1.1.1",
"define-async": "1.2.0",
"elo7-doc-amd": "1.1.1"
},
"devDependencies": {
"bower": "1.7.9",
"express": "4.14.0",
"mocha": "3.0.2",
"express": "4.15.4",
"mocha": "3.5.0",
"mocha-phantomjs": "4.1.0",
"phantomjs-prebuilt": "2.1.12",
"proclaim": "3.4.3"
"phantomjs-prebuilt": "2.1.14",
"proclaim": "3.4.5"
}
}
2 changes: 1 addition & 1 deletion src/tag.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ define('tag', ['doc'], function($) {
var $li = $(document.createElement('li')),
$input = $(document.createElement('input')),
$closeButton = $(document.createElement('button'));
$closeButton.addClass('close').html('×');
$closeButton.attr('type', 'button').addClass('close').html('×');
$input.attr('type', 'hidden').attr('name', $element.attr('name')).val(tag);
$li.text(tag);
$li.addClass('tag').append($input.first());
Expand Down
2 changes: 1 addition & 1 deletion test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ node test/acceptance/test_server.js &
NODE_PID=$!
sleep 3

./node_modules/mocha-phantomjs/bin/mocha-phantomjs -R spec "http://localhost:3000/index.html";
./node_modules/mocha-phantomjs/bin/mocha-phantomjs -p ./node_modules/.bin/phantomjs -R spec "http://localhost:3000/index.html";

0 comments on commit 07e0002

Please sign in to comment.