the minimal change to get webpack 4 to compile #136
Conversation
|
I apologize for the auto-formatting my editor did. The relevant change is on line 37 |
ghost
mentioned this pull request
|
Can you make the change without the auto-formatting? It's hard to see based on the commit what changed, which is needed later if this breaks :) |
index.js
Outdated
| @@ -34,7 +34,7 @@ var getFiles = function(options) { | |||
| }; | |||
|
|
|||
| var getOptions = function() { | |||
| var globalOptions = this.options.elm || {}; | |||
| var globalOptions = this.options ? this.options.elm : {}; | |||
There was a problem hiding this comment.
since the options now became query, the code may look like:
var globalOptions = this.options
? this.options.elm || {}
: this.query.elm || {};
|
@eeue56, @opvasger the build is failing, can we do something? |
|
sometimes, when I run |
| var globalOptions = this.options.elm || {}; | ||
| var globalOptions = this.options | ||
| ? this.options.elm || {} | ||
| : this.query.elm || {}; |
There was a problem hiding this comment.
Do we really want this? Is this.query supported in older versions of webpack?
There was a problem hiding this comment.
logging the properties whilst building from examples:
v1 supports this.options
v2 supports both
v4 supports this.query
|
published as 4.5.0 |
No description provided.