-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete function #194
Add Delete function #194
Conversation
@elliotchance any thoughts? |
Done. One element will be deleted correctly. Added a test for that case. |
I tried a few approaches and chose the best one. I added a little benchmark:
You can find them in separate branch in delete_test.go |
@elliotchance please review |
I believe checking index and bounds is better than keep it without the check and panicking with a bit weird error.