feat: adopt to /api/v2/instance to fetch app vapid_key
#3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
shuuji3
force-pushed
the
shuuji3/feat/prefer-v2-instance-for-vapid-key
branch
from
839e188 to
4766467
Compare
shuuji3
changed the title
/api/v2/instance for fetching app vapid_key/api/v2/instance to fetch app vapid_key
shuuji3
force-pushed
the
shuuji3/feat/prefer-v2-instance-for-vapid-key
branch
from
f74b5d9 to
121a16f
Compare
|
I also added ref. #3193 |
This was referenced Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the vapid key in AppInfo (needed for push notification) is retrieved from the response of
POST /api/v1/appsand stored permanently to the server storage, when someone first tries to log in to the server from the Elk. But it was deprecated since Mastodon v4.3.0 (ref. https://docs.joinmastodon.org/methods/apps/#create). This change uses the recommendedGET /api/v2/instancevalue.This also updates the key of the storage for AppInfo (
servers:v3:${server}:->servers:v4:${server}:) because some (non-Mastodon) servers may return different values with this change. As a side effect, this will partially solve the existing lock-out issue (ref. #3150).Mastodon server returns the exact same vapid key value from
POST /api/v1/appsandGET /api/v2/instance, so there should not be any difference for Mastodon.