Added fallback to English in Journal #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would just not change the image if Journal couldn't find an image file for some language. This fallback does exist on Windows version, but for some reason wasn't implemented for Unix one. I also added some messages to clearly tell what's happening and why it didn't use the locale that was specified in the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would just not change the image if Journal couldn't find an image file for some language. This fallback does exist on Windows version, but for some reason wasn't implemented for Unix one. I also added some messages to clearly tell what's happening and why it didn't use the locale that was specified in the message.
Issue happens only when playing in languages that are available in the game, but weren't added to the Journal (such as Russian) and only on Unix version of it (for Linux and Mac I guess).