Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ClientBase to use a map for managing multiple Twitter clients by account identifier #722

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

tcm390
Copy link
Collaborator

@tcm390 tcm390 commented Nov 30, 2024

related: #656

I think the issue arises because the Scraper instance is shared across different accounts, causing auth and authTrends to be overwritten when a new account is used:
https://github.com/ai16z/agent-twitter-client/blob/e1d86267681c44529ba3dc4b5125e1dc965ed0fc/src/scraper.ts#L665

Verified

This commit was signed with the committer’s verified signature.
aroralanuk Kunal Arora
…s by account identifier
@tcm390 tcm390 marked this pull request as draft November 30, 2024 16:01
@tcm390 tcm390 closed this Nov 30, 2024
@tcm390 tcm390 reopened this Nov 30, 2024
@tcm390 tcm390 marked this pull request as ready for review November 30, 2024 17:46
@lalalune
Copy link
Member

HUGE. This should fix multi agent client issues yeah?!!

@tcm390
Copy link
Collaborator Author

tcm390 commented Nov 30, 2024

HUGE. This should fix multi agent client issues yeah?!!

Yes, I tested with the 2 agents I created

@shakkernerd shakkernerd changed the title Refactor ClientBase to use a map for managing multiple Twitter clients by account identifier refactor: ClientBase to use a map for managing multiple Twitter clients by account identifier Nov 30, 2024
@shakkernerd shakkernerd merged commit 7288127 into main Nov 30, 2024
2 of 3 checks passed
@shakkernerd shakkernerd deleted the tcm-twitter-multiple-agents branch November 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants