Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed ollama embeddings. fastembeddings or openai only #413

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

o-on-x
Copy link
Contributor

@o-on-x o-on-x commented Nov 19, 2024

No description provided.

@o-on-x o-on-x changed the title removed ollama embeddings. fastembeddings or openai only removed ollama embeddings. fastembeddings or openai only pr: fix Nov 19, 2024
@o-on-x o-on-x changed the title removed ollama embeddings. fastembeddings or openai only pr: fix removed ollama embeddings. fastembeddings or openai only fix: embeddings Nov 19, 2024
@o-on-x o-on-x changed the title removed ollama embeddings. fastembeddings or openai only fix: embeddings removed ollama embeddings. fastembeddings or openai only type: fix Nov 19, 2024
@o-on-x o-on-x changed the title removed ollama embeddings. fastembeddings or openai only type: fix fix: removed ollama embeddings. fastembeddings or openai only Nov 19, 2024
@monilpat
Copy link
Collaborator

Thanks for getting this out - LGTM! If there is anyway to add more details in the description as to why it is needed that would be amazing. Otherwise it seems pretty innocuous !

@sirkitree
Copy link
Collaborator

@o-on-x I too would love to hear why this is needed, out of my own curiosity :)

@o-on-x
Copy link
Contributor Author

o-on-x commented Nov 19, 2024

@sirkitree @monilpat i had added this as way to use ollama's embedding endpoints. issue is this switches the model loaded in ollama each time an embedding is needed. at the time of, there was no good local embedding solution. now there is fastembedding. so it makes sense to just have either fastembedding or openai. also this resolves a breaking issue with anyone using ollama on newest codebase. i had added this code, i was removing it now that a better solution exists https://github.com/ai16z/eliza/pull/221/files

@sirkitree sirkitree merged commit 5fa2184 into elizaOS:main Nov 19, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants