Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update web search plugin export #1688

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Conversation

affaan-m
Copy link
Contributor

@affaan-m affaan-m commented Jan 2, 2025

Making sure plugin has a proper default export at bottom to avoid collisions when used in actions module in char file.

Relates to:

Plugin export collisions in character files

Risks

Low - This is a minor bug fix that ensures proper module exports

Background

What does this PR do?

Ensures the bootstrap plugin has a proper default export at the bottom to avoid collisions when used in the actions module in character files. This maintains consistency with other plugins in the codebase that follow the same pattern (like the EVM plugin).

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

  1. Check packages/plugin-bootstrap/src/index.ts to verify the proper export structure
  2. Verify that the plugin can be properly imported in character files without collisions

Detailed testing steps

  1. Load a character file that uses the bootstrap plugin
  2. Verify that no export collisions occur when the plugin is loaded
  3. Verify that all plugin actions are properly accessible

Deploy Notes

No special deploy steps required. This is a straightforward bug fix that maintains backward compatibility.

Discord

affaanmustafa

Making sure plugin has a proper default export at bottom to avoid collisions when used in actions module in char file.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @affaan-m! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@monilpat monilpat changed the base branch from main to develop January 2, 2025 16:36
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shakkernerd shakkernerd changed the title Update index.ts chore: update web search plugin export Jan 2, 2025
@shakkernerd shakkernerd merged commit 9308f5c into elizaOS:develop Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants