Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add required incremental option and remove invalid typescript configuration #1485

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

ShaneOxM
Copy link
Contributor

@ShaneOxM ShaneOxM commented Dec 27, 2024

Relates to:

No specific issue ticket - fixing TypeScript configuration errors encountered during build

Risks

Low - Configuration changes only, no functional code changes

  • Affects TypeScript compilation settings
  • No runtime behavior changes
  • Only impacts development/build time performance

Background

What does this PR do?

Fixes two TypeScript configuration issues:

  1. Adds required incremental option for tsBuildInfoFile usage
  • 'tsBuildInfoFile' is used for incremental compilation but requires 'incremental: true'
  • This change will improve build performance by enabling proper incremental builds
  1. Removes invalid compiler option noUncheckedSideEffectImports
  • This option is not a valid TypeScript compiler option
  • Removing it resolves the TypeScript configuration error

These changes resolve the following errors:

Option 'tsBuildInfoFile' cannot be specified without specifying option 'incremental'
Unknown compiler option 'noUncheckedSideEffectImports'

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

  • Improves TypeScript configuration
  • Enables proper incremental builds
  • Removes invalid configuration option

Documentation changes needed?

My changes do not require a change to the project documentation as they only affect internal TypeScript configuration.

Testing

Where should a reviewer start?

Review the changes in:

  1. client/tsconfig.app.json
  2. client/tsconfig.node.json

Detailed testing steps

  1. Clone the repository and checkout this branch
  2. Install dependencies:
cd client
pnpm install
  1. Run TypeScript compilation to verify errors are resolved:
pnpm check-types
  1. Verify no TypeScript configuration errors are reported
  2. Run the development server to ensure everything works:
pnpm dev

Deploy Notes

No special deploy steps required - changes only affect development/build configuration

  • Build performance may improve due to proper incremental compilation
  • No runtime changes or dependencies affected

@monilpat monilpat changed the base branch from main to develop December 27, 2024 02:08
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@monilpat monilpat merged commit 2633a5e into elizaOS:develop Dec 28, 2024
3 checks passed
1to3for5vi7ate9x pushed a commit to 1to3for5vi7ate9x/eliza that referenced this pull request Jan 26, 2025
fix: add required incremental option and remove invalid typescript configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants