Update farcaster client max cast length #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Medium risk: I don't know if neynar's APIs support long casts with 1024 length without any additional flags as I couldn't find the limit documented or if there are any other parameters except for
textin their publishCast function. I don't have an account to test it. The value takes into consideration the byte length of the cast, so maybe unicode characters of 1024 length will fail.Background
What does this PR do?
What kind of change is this?
The cast limit for farcaster client has been modified to match the protocol's spec
Why are we doing this? Any context or related work?
I wanted it to match the spec instead of the currently incorrectly defined limit
Documentation changes needed?
I don't think there's any documentation for the Farcaster client at the moment
Testing
Where should a reviewer start?
If you have a neynar account try posting a cast with a message size of 1024 bytes