-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitBook Plugin provider #1126
Merged
shakkernerd
merged 24 commits into
elizaOS:develop
from
azep-ninja:feature/add-gitbook-provider
Dec 28, 2024
Merged
feat: Add GitBook Plugin provider #1126
shakkernerd
merged 24 commits into
elizaOS:develop
from
azep-ninja:feature/add-gitbook-provider
Dec 28, 2024
+203
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this sounds useful 👍 |
Updated all files to elizaos. Ready to merge @odilitime |
your branch seems out of date. can you pull / rebase your branch @azep-ninja |
@samarth30 branch has been updated. |
shakkernerd
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
N/A
Risks
Low: Adding new features
Background
What does this PR do?
Adds a new GitBook documentation plugin that enables:
What kind of change is this?
Features:
Documentation changes needed?
Yes, my changes require updates to the project documentation:
Testing
Where should a reviewer start?
Review the plugin implementation in:
plugin-gitbook/src/providers/gitbook.ts
plugin-gitbook/src/types.ts
plugin-gitbook/src/index.ts
Check the character configuration handling
Detailed testing steps
Configure GitBook space ID:
GITBOOK_SPACE_ID=your_space_id
Test with different configurations: