Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #226

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Fix ci #226

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf6d654
updated minimum elixir version due to ecto dependency
Jul 8, 2024
aefd988
make ci run on PRs
Jul 8, 2024
03afffd
Update .github/workflows/ci.yml
gabrielperales Jul 8, 2024
1ccf8eb
tweaks
Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
on: push
on:
push:
pull_request:
branches: [master]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that removing push here made it so that now it doens't run CI on master branch, only pull requests.

types: [opened, synchronize, reopened]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me we can just run CI on any PR

Suggested change
on:
push:
pull_request:
branches: [master]
types: [opened, synchronize, reopened]
on:
pull_request:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI badge is not working properly after removing on: push 😓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielperales No problem. I would fix them

jobs:
test:
Expand All @@ -10,7 +14,7 @@ jobs:
- otp: 25.1
elixir: 1.15.4
- otp: 21.3
Nitrino marked this conversation as resolved.
Show resolved Hide resolved
elixir: 1.7.4
elixir: 1.11.4

Nitrino marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v3
Expand Down
Loading