Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error #434

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

MasashiYokota
Copy link
Contributor

I've fixed a type error on Tesla.MultiPart.add_file/3.

I've simply removed its option because there is no :read option for File.stream!/3.
If this patch has any problems. please let me know.

Thank you!

@tanguilp
Copy link
Contributor

Thank you @MasashiYokota

This incorrect parameter causes Dialyzer to emit warnings in projects using Tesla. Surprisingly, it doesn;t when running it on the tesla library alone.

:read isn't a valid option indeed for streaming files, as specified here: https://hexdocs.pm/elixir/1.11.3/File.html#stream!/3

@teamon teamon merged commit ffe84a6 into elixir-tesla:master Jan 29, 2021
@teamon
Copy link
Member

teamon commented Jan 29, 2021

Thanks!

@MasashiYokota MasashiYokota deleted the fix-dialyzer-error branch February 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants