Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesla 1.9.0+ is not compatible with Elixir 1.10 #694

Closed
halostatue opened this issue Jul 2, 2024 · 2 comments · Fixed by #695
Closed

Tesla 1.9.0+ is not compatible with Elixir 1.10 #694

halostatue opened this issue Jul 2, 2024 · 2 comments · Fixed by #695

Comments

@halostatue
Copy link
Contributor

Tesla advertises itself in its mix.exs as compatible with Elixir ~> 1.10, but since #540, the use of is_struct/2 has made that incorrect.

This should at least be documented by updating mix.exs and advising people in the README/documentation that older versions must use Tesla 1.8 or lower. A "correct" fix for this is somewhat nightmarish (it would involve making hot fix releases for 1.9.x, 1.10.x, and 1.11.x) and using pattern matching (%mod{} … where mod == Stream) on those and then making Tesla 1.12 or later ~> 1.11 (or later!) only.

@yordis
Copy link
Member

yordis commented Jul 2, 2024

Do you mind changing the elixir to 1.14+ and clarifying in the readme?

@halostatue
Copy link
Contributor Author

I won't have time until next week to do so (I know it’s light, but today's "dependency update day", so my regular workday has gone by the wayside).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants