Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around missing function support #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dominicletz
Copy link

This fixes two issues:

  1. crypto.hash_equals can be present but unsupported (in which case it throws)

  2. When compiling beam files on a newer otp revision than deploying , the compile time detection reports false positives. Instead we're using runtime detection now always.

@josevalim
Copy link
Member

When compiling beam files on a newer otp revision than deploying , the compile time detection reports false positives. Instead we're using runtime detection now always.

We can expand on this a bit? I don't believe Elixir nor the Erlang VM actually supports compiling on a newer OTP version. You should always compile on the lowest version that you plan to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants