Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import datasets, projects and partners using the ui #479

Merged
merged 14 commits into from
Oct 27, 2023
Merged

Import datasets, projects and partners using the ui #479

merged 14 commits into from
Oct 27, 2023

Conversation

moustaphacheikh
Copy link
Collaborator

@moustaphacheikh moustaphacheikh commented Oct 24, 2023 •
edited
Loading

This PR introduces the import_data view, enabling data imports for various models using the UI.

Highlights:

  1. AJAX-Driven: Ensures a smooth user experience without full-page reloads.
  2. Access Controls: Only users in Groups.DATA_STEWARD can import data, ensuring restricted access.
  3. File Handling: Efficient processing and automatic cleanup of uploaded files.
  4. Testing: Parameterized tests for both GET and POST requests across different model types.
Screenshot 2023-10-24 at 12 22 29 Screenshot 2023-10-24 at 12 21 04 Screenshot 2023-10-24 at 12 20 40 Screenshot 2023-10-24 at 12 20 54

@moustaphacheikh moustaphacheikh linked an issue Oct 24, 2023 that may be closed by this pull request
DISH import button #438
Closed
@vildead
Copy link
Member

vildead commented Oct 24, 2023

data/demo/partners.json seems to contain project not partners

@vildead
Copy link
Member

vildead commented Oct 24, 2023 •
edited
Loading

I have no other comments except the one above :)

It looks really nice!

Fancien
Fancien requested changes Oct 26, 2023
View reviewed changes
web/templates/_includes/search_form.html Outdated Show resolved Hide resolved
web/templatetags/daisy_utils.py Outdated Show resolved Hide resolved
web/templates/importer/import_form.html Outdated Show resolved Hide resolved
web/templates/importer/import_modal.html Outdated Show resolved Hide resolved
web/tests/views/test_importer_views.py Outdated Show resolved Hide resolved
web/tests/views/test_importer_views.py Outdated Show resolved Hide resolved
web/views/importer.py Outdated Show resolved Hide resolved
web/views/importer.py Outdated Show resolved Hide resolved
web/views/importer.py Show resolved Hide resolved
web/views/importer.py Show resolved Hide resolved
Fancien
Fancien reviewed Oct 26, 2023
View reviewed changes
web/tests/views/test_importer_views.py Outdated Show resolved Hide resolved
web/tests/views/test_importer_views.py Outdated Show resolved Hide resolved
@Fancien Fancien merged commit 19badf8 into develop Oct 27, 2023
2 checks passed
@vildead vildead deleted the 438-dish-import-button branch July 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fancien Fancien Fancien approved these changes

@neoflex neoflex Awaiting requested review from neoflex

@nirmeen nirmeen Awaiting requested review from nirmeen

@HesamKorki HesamKorki Awaiting requested review from HesamKorki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DISH import button
3 participants
@moustaphacheikh @vildead @Fancien